Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shell): fix schema requiring sidecar property even though it is optional #1839

Open
wants to merge 3 commits into
base: v2
Choose a base branch
from

Conversation

amrbashir
Copy link
Member

No description provided.

@amrbashir amrbashir requested a review from a team as a code owner September 25, 2024 01:08
Copy link
Contributor

github-actions bot commented Sep 25, 2024

Package Changes Through dc410cd

There are 5 changes which include deep-link with prerelease, dialog with prerelease, fs with prerelease, shell with prerelease, updater with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.0-rc.7 2.0.0-rc.8
deep-link 2.0.0-rc.6 2.0.0-rc.7
fs 2.0.0-rc.5 2.0.0-rc.6
dialog 2.0.0-rc.7 2.0.0-rc.8
http 2.0.0-rc.5 2.0.0-rc.6
persisted-scope 2.0.0-rc.5 2.0.0-rc.6
shell 2.0.0-rc.3 2.0.0-rc.4
single-instance 2.0.0-rc.4 2.0.0-rc.5
updater 2.0.0-rc.3 2.0.0-rc.4

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member

schema noob here: Is it possible to say that either cmd or sidecar is required? Because now only name is required and that alone doesn't do anything. No biggie if this is not possible but wanted to ask just in case it is.

@amrbashir
Copy link
Member Author

schema noob here: Is it possible to say that either cmd or sidecar is required? Because now only name is required and that alone doesn't do anything. No biggie if this is not possible but wanted to ask just in case it is.

It is probably possible with a custom JsonSchema implementation, I don't think we can do it with the derive macro

FabianLars
FabianLars previously approved these changes Sep 26, 2024
@amrbashir
Copy link
Member Author

@FabianLars actually we could just use untagged enum, take a look and see if that's what you meant

@FabianLars
Copy link
Member

I don't have access to a computer until tomorrow so I can't check out the generated schema but I assume this is what I meant, or at least close enough x)

@FabianLars
Copy link
Member

Okay so I got my hands on my laptop for a minute 😂 It seems to work, cool. vscode just seems to think that args is always required though.

Laptop is gone again so now I really can't test again until tomorrow but with just the args thing I don't think that's a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants